Skip to content

Adjust enum reprs conditional from Python 3.10 to 3.11#8895

Closed
hroncok wants to merge 1 commit into
pytest-dev:mainfrom
hroncok:python-3.10.0b4
Closed

Adjust enum reprs conditional from Python 3.10 to 3.11#8895
hroncok wants to merge 1 commit into
pytest-dev:mainfrom
hroncok:python-3.10.0b4

Conversation

@hroncok

@hroncok hroncok commented Jul 12, 2021

Copy link
Copy Markdown
Member

I don't think a changelog fragment is necessary: It changes tests only, no chnagelog fragment was even in the original commit that introduced the condiitonal.

@hroncok hroncok added the type: selftests a problem in the tests of pytest label Jul 12, 2021
@The-Compiler

Copy link
Copy Markdown
Member

FWIW I'd prefer a revert of those changes - according to the discussion, there are potentially incompatible changes planned for 3.11, and there will be a PEP written first - so at this point, it seems very speculative to me to already have our tests handle the new format when we have no idea how it'll end up looking like.

@The-Compiler The-Compiler added this to the 7.0 milestone Jul 12, 2021
@hroncok

hroncok commented Jul 12, 2021

Copy link
Copy Markdown
Member Author

Fine by me ;)

@hroncok

hroncok commented Jul 12, 2021

Copy link
Copy Markdown
Member Author

Alternative approach (full revert) in #8896

@nicoddemus

nicoddemus commented Jul 12, 2021

Copy link
Copy Markdown
Member

FWIW I'd prefer a revert of those changes - according to the discussion, there are potentially incompatible changes planned for 3.11, and there will be a PEP written first - so at this point, it seems very speculative to me to already have our tests handle the new format when we have no idea how it'll end up looking like.

Agreed, thanks for pointing that out. I thought the changes would land in 3.11, so why not just adjust the code? But given more discussion will certainly follow, then I agree completely.

@nicoddemus

Copy link
Copy Markdown
Member

Closing in favor of #8896.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: selftests a problem in the tests of pytest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants